Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add style_name property to font and freetype font #2175

Merged
merged 24 commits into from
Jul 29, 2023
Merged

add style_name property to font and freetype font #2175

merged 24 commits into from
Jul 29, 2023

Conversation

dr0id
Copy link
Contributor

@dr0id dr0id commented May 18, 2023

partial PR as requested in this PR #2132

@dr0id dr0id requested a review from a team as a code owner May 18, 2023 13:28
@dr0id dr0id mentioned this pull request May 18, 2023
Merged
narilee2006
narilee2006 reviewed May 19, 2023
View reviewed changes
src_c/font.c Outdated Show resolved Hide resolved
@novialriptide novialriptide added the font pygame.font label May 19, 2023
@novialriptide novialriptide added this to the 2.3 milestone May 19, 2023
Starbuck5
Starbuck5 reviewed May 21, 2023
View reviewed changes
docs/reST/ref/font.rst Outdated Show resolved Hide resolved
Starbuck5
Starbuck5 reviewed May 21, 2023
View reviewed changes
src_c/_freetype.c Outdated Show resolved Hide resolved
Starbuck5
Starbuck5 reviewed May 21, 2023
View reviewed changes
src_c/font.c Outdated Show resolved Hide resolved
@Starbuck5
Copy link
Member

Thanks for the PR!

One additional thing I noticed is that this should have some small unit tests added.

@dr0id
Copy link
Contributor Author

dr0id commented May 23, 2023

I have added a test for the new property

@ankith26 ankith26 added the New API This pull request may need extra debate as it adds a new class or function to pygame label May 25, 2023
Starbuck5
Starbuck5 reviewed May 28, 2023
View reviewed changes
src_c/font.c Outdated Show resolved Hide resolved
@MightyJosip MightyJosip changed the title add stylename property to freetype font add style_name property to freetype font May 30, 2023
@dr0id dr0id changed the title add style_name property to freetype font add style_name property to font and freetype font May 30, 2023
@Starbuck5 Starbuck5 modified the milestones: 2.3, 2.3.1 Jun 10, 2023
@dr0id
Copy link
Contributor Author

dr0id commented Jun 21, 2023

@Starbuck5 @narilee2006 @novialriptide @ankith26
updated, please review again

Starbuck5
Starbuck5 reviewed Jul 8, 2023
View reviewed changes
docs/reST/ref/font.rst Outdated Show resolved Hide resolved
Starbuck5
Starbuck5 reviewed Jul 8, 2023
View reviewed changes
src_c/font.c Outdated Show resolved Hide resolved
Starbuck5
Starbuck5 reviewed Jul 8, 2023
View reviewed changes
src_c/font.c Show resolved Hide resolved
@dr0id
Copy link
Contributor Author

dr0id commented Jul 26, 2023

@Starbuck5 @zoldalma999 @narilee2006
updated, I would like to finish this PR within this week.

ankith26
ankith26 reviewed Jul 26, 2023
View reviewed changes
buildconfig/stubs/pygame/freetype.pyi Show resolved Hide resolved
docs/reST/ref/freetype.rst Outdated Show resolved Hide resolved
ankith26
ankith26 requested changes Jul 27, 2023
View reviewed changes
src_c/font.c Outdated Show resolved Hide resolved
@dr0id dr0id requested a review from ankith26 July 27, 2023 19:31
ankith26
ankith26 reviewed Jul 28, 2023
View reviewed changes
test/font_test.py Show resolved Hide resolved
src_c/_freetype.c Outdated Show resolved Hide resolved
src_c/_freetype.c Outdated Show resolved Hide resolved
@dr0id dr0id requested review from ankith26 and Starbuck5 July 29, 2023 05:30
ankith26
ankith26 approved these changes Jul 29, 2023
View reviewed changes
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR 👍

Starbuck5
Starbuck5 approved these changes Jul 29, 2023
View reviewed changes
Copy link
Member

@Starbuck5 Starbuck5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this merged!

@Starbuck5 Starbuck5 merged commit 6d0c42e into pygame-community:main Jul 29, 2023
31 of 32 checks passed
This was referenced Jul 29, 2023
Merged
Merged
@Starbuck5 Starbuck5 mentioned this pull request Aug 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoldalma999 zoldalma999 zoldalma999 left review comments

@narilee2006 narilee2006 narilee2006 left review comments

@Starbuck5 Starbuck5 Starbuck5 approved these changes

@ankith26 ankith26 ankith26 approved these changes

Assignees
No one assigned
Labels
font pygame.font New API This pull request may need extra debate as it adds a new class or function to pygame
Projects
None yet
Milestone
2.3.1
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dr0id @Starbuck5 @zoldalma999 @ankith26 @narilee2006 @novialriptide