-
-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/font stubs #2358
Bugfix/font stubs #2358
Conversation
What am I looking at? I see a bazillion formatting changes, and attributes are |
The changes are in All the other changes are just formatting changes after running: Not sure why I have those changes, but ci builds seems not to bothered by those changes. I'm using: |
RN |
You are right, I run (from my setup.py):
Right now from the setup.py only following python directories would be touched:
|
This reverts commit 7fa8e19.
removed linting changes @ankith26 |
update return type of style from None to int Co-authored-by: Ankith <46915066+ankith26@users.noreply.github.com>
freetype.pyi: use ColorValue for color parameters
change color getters back to return Color instead of ColorValue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the PR 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Clear what the change is now, and I approve.
follow up PR of #2175 to fix the stubs of all properties in font and freetype