Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't allow font API usage when subsystem is not init #2371

Merged
merged 25 commits into from
Oct 3, 2023
Merged

Don't allow font API usage when subsystem is not init #2371

merged 25 commits into from
Oct 3, 2023

Conversation

dr0id
Copy link
Contributor

@dr0id dr0id commented Aug 2, 2023

follow up pr for #2175, related to #1506 and #2255

@yunline yunline added Android font pygame.font bugfix PR that fixes bug freetype pygame.freetype and removed Android font pygame.font labels Aug 2, 2023
@dr0id dr0id mentioned this pull request Aug 2, 2023
Merged
dr0id added 13 commits August 2, 2023 18:50
@dr0id
font: try to fix other compiler compilation errors
3f35e66
@dr0id
freetype: fix macro compilation error
ef697d2
@dr0id
font_test: avoid calling 'align'
e080b5a
@dr0id
font_test: remove align from test code if SDL version is < 2.20.0
59cbab4
@dr0id
font_test.py: add print message to find out which property/method is …
a129f72 
…causing trouble
@dr0id
font_test.py: fix point_size too which is available for SDL >= 2.0.18
e95bc87
@dr0id
font_test.py: fix typo
965615d
@dr0id
font_test.py: skip the point_size property too in the methods test case
2021788
@dr0id
freetype: rename macro to satisfy WASM emscripten build
fb93d1d
@dr0id
font_test and freetype_test: remove debug prints and other unwanted c…
887a3ce 
…hanges
@dr0id
Merge main
a357621
@dr0id
freetype_test: change ft.name AttributeError to RuntimeError when the…
3a21c0c 
… font is not initialized.
@dr0id
Merge remote-tracking branch 'origin/main' into enhancement/font/chec…
23adc3d 
…k_initialization
@dr0id dr0id marked this pull request as ready for review August 17, 2023 20:39
@dr0id dr0id requested a review from a team as a code owner August 17, 2023 20:39
ankith26
ankith26 reviewed Aug 19, 2023
View reviewed changes
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this has a larger than needed diff, could you rebase against main?

@dr0id
Copy link
Contributor Author

dr0id commented Aug 19, 2023

Not sure why this has a larger than needed diff, could you rebase against main?

Not sure why the line endings are messed up! This is the only reason I see this diff is so large.

MyreMylar
MyreMylar approved these changes Sep 24, 2023
View reviewed changes
Copy link
Member

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff looks good to me now. We've had a lot of these quit() then use segfault errors crop up, good to clear out one more.

This will definitely need a squash and merge by the looks of things.

ankith26
ankith26 approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left two minor reviews for you resolve at will, but apart from that this PR LGTM, thanks 🍰

@ankith26 ankith26 added this to the 2.4.0 milestone Sep 26, 2023
@dr0id dr0id requested a review from ankith26 September 30, 2023 14:17
ankith26
ankith26 approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR 🎉

@ankith26 ankith26 merged commit 754c2e9 into pygame-community:main Oct 3, 2023
32 checks passed
@dr0id dr0id mentioned this pull request Nov 5, 2023
Merged
@ankith26 ankith26 changed the title Enhancement/font/check initialization Don't allow font API usage when subsystem is not init Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MyreMylar MyreMylar MyreMylar approved these changes

@ankith26 ankith26 ankith26 approved these changes

Assignees
No one assigned
Labels
bugfix PR that fixes bug font pygame.font freetype pygame.freetype
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dr0id @MyreMylar @ankith26 @yunline