Fix the LGTM alerts in setup_win_common.py

[charlesej]

Overview of changes:

• Fixed the LGTM alerts in setup_win_common.py
  (LGTM info for pygame: https://lgtm.com/projects/g/pygame/pygame)

System details:

• os: windows 10 (64bit)
• python: 3.7.4 (64bit) and 2.7.10 (64bit)
• pygame: 2.0.0.dev3 (SDL: 2.0.10) at 1556f34

Resolves the setup_win_common.py alerts from the LGTM link in #1133.

[lgtm-com]

This pull request fixes 2 alerts when merging 50e54d9 into 1556f34 - view on LGTM.com

fixed alerts:

• 2 for Should use a 'with' statement

[illume]

Seems this takes the pattern matching outside of the try/except as well as using a with context manager for the open. I guess that doesn't matter, as it seems to work.

[illume]

Thanks

[charlesej]

Thanks for reviewing the changes.

This was addressing 2 LGTM alerts of type: "Instance of context-manager class file is closed in a finally block. Consider using 'with' statement."

In the get_definitions() function I thought moving that code (it doesn't require the file to be open) outside the with context manager was okay, since the finally block was only being used to close the file.

Probably should have included this information in the initial description of the changes.

[illume]

Thanks for the explanation. Makes sense to me :)