Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an LGTM alert in download_win_prebuilt.py #1362

Merged

Conversation

charlesej
Copy link
Contributor

Overview of changes:

System details:

  • os: windows 10 (64bit)
  • python: 3.7.4 (64bit) and 2.7.10 (64bit)
  • pygame: 2.0.0.dev3 (SDL: 2.0.10) at 8a937fc

Resolves a download_win_prebuilt.py alert from the LGTM link in #1133.

- Fixed the “Except block directly handles BaseException” LGTM alert in
  download_win_prebuilt.py
  (LGTM info for pygame: https://lgtm.com/projects/g/pygame/pygame)
- Added missing stat module import
@lgtm-com
Copy link

lgtm-com bot commented Oct 2, 2019

This pull request fixes 1 alert when merging 4ed2431 into 8a937fc - view on LGTM.com

fixed alerts:

  • 1 for Except block handles 'BaseException'

Copy link
Member

@illume illume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@illume illume merged commit b37c0d1 into pygame:master Oct 3, 2019
@charlesej charlesej deleted the fix-download-win-prebuilt-lgtm-alert branch October 3, 2019 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants