Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the LGTM alerts in config_win.py #1433

Merged
merged 1 commit into from
Oct 18, 2019

Conversation

charlesej
Copy link
Contributor

Overview of changes:

System details:

  • os: windows 10 (64bit)
  • python: 3.7.4 (64bit) and 2.7.10 (64bit)
  • pygame: 2.0.0.dev5 (SDL: 2.0.10) at 1b3a971

Resolves the config_win.py alerts from the LGTM link in #1133.

- Fixed the following LGTM alerts in config_win.py
  (LGTM info for pygame: https://lgtm.com/projects/g/pygame/pygame)
  - 2 alerts labeled: Except block directly handles BaseException.
@lgtm-com
Copy link

lgtm-com bot commented Oct 17, 2019

This pull request fixes 2 alerts when merging f39e31d into 1b3a971 - view on LGTM.com

fixed alerts:

  • 2 for Except block handles 'BaseException'

Copy link
Member

@illume illume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Grand to me! Thanks.

@illume illume merged commit 1bee822 into pygame:master Oct 18, 2019
@charlesej charlesej deleted the fix-config-win-lgtm-alerts branch October 19, 2019 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants