Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused gp2x files. #1917

Merged
merged 1 commit into from Jun 5, 2020
Merged

Remove unused gp2x files. #1917

merged 1 commit into from Jun 5, 2020

Conversation

illume
Copy link
Member

@illume illume commented Jun 5, 2020 •
edited

gp2x was a 2000s era indie handheld, such constants are not needed
even for people who may have the thing working.

related LGTM issue: #1133

@illume
Remove unused gp2x files.
6e040c7 
gp2x was a 2000s era indie handheld, such constants are not needed
even for people who may have the thing working.
@lgtm-com
Copy link

lgtm-com bot commented Jun 5, 2020

This pull request fixes 1 alert when merging 6e040c7 into baaa34f - view on LGTM.com

fixed alerts:

  • 1 for 'import *' may pollute namespace

@MyreMylar
Copy link
Contributor

Looks good to me. 👍

@illume illume merged commit 0a7a554 into master Jun 5, 2020
@illume illume deleted the remove-gp2x branch June 5, 2020 09:47
MightyJosip
MightyJosip suggested changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@MightyJosip MightyJosip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you changed constants.py can you run the commented code at the top of constants.pyi and then replace constants.pyi with the output of it

@illume
Copy link
Member Author

illume commented Jun 5, 2020

This removes pygame.gp2x, it doesn't touch pygame.constants :)

@MightyJosip
Copy link
Contributor

Oh looks like I read pygame.gp2x.constants as pygame.constants

@illume illume added the Code quality/robustness Code quality and resilience to changes label Sep 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MightyJosip MightyJosip MightyJosip requested changes

@MyreMylar MyreMylar MyreMylar approved these changes

Assignees
No one assigned
Labels
Code quality/robustness Code quality and resilience to changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@illume @MyreMylar @MightyJosip