Do MOUSEBUTTONUP event on MOUSEWHEEL #2242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested this PR locally, and it works as expected |
|
Overall, this PR makes many changes to ensure that output is much more similar to pygame 1.9.6 |
siggisv
reviewed
Oct 24, 2020
| @@ -157,6 +157,14 @@ _pg_remove_pending_PGS_VIDEOEXPOSE(void * userdata, SDL_Event *event) | |||
| return 1; | |||
| } | |||
|
|
|||
| static int | |||
There was a problem hiding this comment.
Small note: C already has a function, int abs(int n), defined in <stdlib.h>, that does exactly what this function is doing (see: https://en.cppreference.com/w/c/numeric/math/abs).
There was a problem hiding this comment.
Hmmm ok, I didn’t know it was there. Anyways, we can save an include by defining the function ourselves right ;)
illume
approved these changes
Oct 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably fixes #2240