Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop PyLong_FromUnicode, removed in python 3.10 [skip ci] #2385

Merged
merged 1 commit into from
Dec 21, 2020

Conversation

ankith26
Copy link
Contributor

@ankith26 ankith26 commented Dec 8, 2020

PyLong_FromUnicode will be removed in python 3.10 (which is coming soon).
So we should drop it as well.
See
https://docs.python.org/3.10/whatsnew/3.10.html#id4

Copy link
Contributor

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 We'll also need to upgrade our version of Cython at the time of 3.10 as the current version of the generated files also include this function.

@ankith26
Copy link
Contributor Author

@illume this PR is ready to get merged too. This is a super minor change, that does not affect anything. So this should be an easy one

Thanks :)

Copy link
Member

@illume illume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@illume illume merged commit be4ed6c into main Dec 21, 2020
@ankith26 ankith26 deleted the ankith26-py3.10-support branch December 21, 2020 17:16
@illume illume added this to the 2.0.1 milestone Aug 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants