Fix playmus.py example (broken in 2.0.1) #2745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For the documentation note, I’d rather have it say that it doesn’t support WAV, than just listing all other file types mixer.music supports. |
Done, updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is identical to PR #2738 which I closed as I needed to update base code to prevent automated build test failures.
=====
This PR is to fix an issue with the bundled example file playmus.py which stopped working correctly as of pygame 2.0.1 due to a change in returning False for pygame.mixer.music.get_busy() when music is paused (previously returned True).
Color scheme updated to be easier on the eye
Docs updated to reflect that rewind() is only supported for certain file types
Tidied up the wording in playmus.py a little bit and fixed a typo
Related to a closed issue that was raised under #2734