Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playmus example is broken #2734

Closed
Starbuck5 opened this issue Sep 26, 2021 · 1 comment · Fixed by #2745
Closed

Playmus example is broken #2734

Starbuck5 opened this issue Sep 26, 2021 · 1 comment · Fixed by #2745
Labels

Comments

@Starbuck5
Copy link
Contributor

@cassiobotaro put in a PR, #2731, to fix the playmus example being broken in 2.0.1.

The fix they proposed is actually necessary for 2.0.1, but it looks like the underlying issue has been fixed by now in 2.0.2.dev.

But there seem to be no shortage of other things wrong with this example:

Now that I'm looking at this though, there are some other problems. There's a typo - "faid" should be "fade." There also seems to be problems with rewinding and pausing. On 2.0.2.dev2, pausing just closes the window- that shouldn't happen. In 2.0.0, where pausing does work, rewinding doesn't seem to actually work.

It just needs some TLC, some tender loving care.

@rethanon
Copy link
Contributor

@Starbuck5
The issue with the program exiting when the music is paused is due to a change in pygame 2.0.1 which updated pygame.music.mixer.get_busy() to return False when music is paused, in previous versions it returned True (and playmus.py closes when no music is playing).

I should be able to give this a bit of love to get it working properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants