python3 setup.py lint
is deprecated: Let's lint with pre-commit
#4200
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
python3 setup.py lint
is deprecated. https://packaging.python.org/en/latest/discussions/setup-py-deprecatedThe
setup.py
logic for runningblack
andclang-format
is ~100 lines long and is skipping many Python and C files.pygame/setup.py
Lines 871 to 964 in 9cb30af
This pull request proposes using
pre-commit
with ~25 lines of configuration to rapidly run these two tools locally on contributors' machines and also in our GitHub Actions to cover any contributors who do not havepre-commit
installed.The 15
exclude
lines should be removed gradually as more of the codebase passes the formatting and linting process.How to use: