Remove lint logic from setup.py

[cclauss]

After #4200 is merged remove lint logic from setup.py

• python3 setup.py lint is deprecated: Let's lint with pre-commit #4200

To replace the commands that were removed from setup.py, the following will work...

• pre-commit run black
• pre-commit run clang-format
• pre-commit run --all-files

[illume]

Hi, Thanks for this.

I think we still need a place to put commands that can be run during development. But I'm not sure if there even is a new place in whatever the latest python packaging way is to do this? In old Makefile projects this might be in make check. npm projects have a package.json scripts. Rust projects have task runners like cargo make. Seems tasks aren't standardised in python yet... except in distutils/setuptools commands.

I left a note about the docs check in CI probably still needing to be there. I guess that will move to precommit too eventually?

[cclauss]

we still need a place to put commands that can be run during development

The following will work...

• pre-commit run black
• pre-commit run clang-format
• pre-commit run --all-files

[illume]

👍 thanks

[illume]

Not related to this PR exactly...

I noticed the pre-commit that comes with Ubuntu 22.04 is a bit too old for our config. There also aren't any install instructions for pre-commit with Ubuntu and other OS that work for me on the install page https://pre-commit.com/#install
(I installed with pip into my pyenv bin folder, but I guess we will need better pre-commit install instructions for folks on windows/Ubuntu)