Skip to content

Commit

Permalink
Update PULL_REQUEST_REVIEW_CHECKLIST.md
Browse files Browse the repository at this point in the history
  • Loading branch information
arnauddupuis committed Oct 16, 2020
1 parent 9269cb5 commit aa9d3ba
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions PULL_REQUEST_REVIEW_CHECKLIST.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ This is the checklist that all PR are going through, so as a potential contribut

- [ ] If it does too much, ask for it to be broken up into smaller PRs.
- [ ] Does it pass flake8?
- [ ] Have you run `black` on your code to comply with code formatting rules (https://black.readthedocs.io/en/stable/)?
- [ ] Is it consistent?
- [ ] Review the changes carefully, line by line. Make sure you understand every single part of every line. Learn whatever you do not know yet.
- [ ] Take the time to get things right. PRs almost always require additional improvements to meet the bar for quality. Be very strict about quality. This usually takes several commits on top of the original PR.
Expand Down

0 comments on commit aa9d3ba

Please sign in to comment.