Improve Skeleton's transform performance #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 13, 2024
Merged
panxinmiao
force-pushed
the
transform-perf
branch
from
24c16fe
to
a0e89a3
Compare
|
Rebased now. |
Korijn
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround to improve skeletal animation performance, serving as a temporary solution before we resolve the current performance issues with the Transform system.
See: #715 (comment)
Since Bone objects tend to have complex parent-child relationship graphs in most scenarios, the current automatic recursive calculation of transforms has a significant performance impact on Bones and Skeletons.
This PR employs certain tricks to prevent the automatic recursive calculation of the matrix for Bone objects.
We definitely need to address the performance issues of the current Transform system eventually. Once resolved, the contents of this PR can be removed, and the Bone objects will simply be regular blank WorldObjects.