Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grayscale texture render tests #89

Merged
merged 5 commits into from
Apr 15, 2020
Merged

Fix grayscale texture render tests #89

merged 5 commits into from
Apr 15, 2020

Conversation

almarklein
Copy link
Collaborator

Closes #73

So the problem appeared to be the compare arg in create_sampler. It apparently must be set to "undefined". Except ... there is no wgpu.CompareFunction.undefined. Fortunately, we can just set it to zero for now.

@Korijn
Copy link
Collaborator

Korijn commented Apr 15, 2020

Oh well :) LGTM

@almarklein almarklein merged commit 89e94fd into master Apr 15, 2020
@almarklein almarklein deleted the textests branch April 15, 2020 13:39
@almarklein almarklein mentioned this pull request Apr 15, 2020
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for grayscale textures
2 participants