Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for .tid files (TiddlyWiki5) #1390

Merged
merged 5 commits into from May 24, 2020

Conversation

MaxGyver83
Copy link
Contributor

This PR extends the markup lexer by support for .tid files (TiddlyWiki5).

TiddlyWiki has it's own syntax. When it is used in it's Node.js variant, every article ("tiddler") is being saved as a .tid file. A tid file can contain WikiText syntax, TiddlyWiki macros as well as HTML tags, CSS style blocks and usually some meta data.

This is how the example file looks like when it's rendered with the new lexer:

grafik

@MaxGyver83
Copy link
Contributor Author

Meanwhile five weeks have passed and this PR didn't get a single comment. Are there any reasons for not merging?

@Anteru Anteru self-assigned this Apr 10, 2020
Copy link
Collaborator

@Anteru Anteru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please take a look at the requested changes? (Apparently they didn't show up until I hit the "request changes" button ... sorry about that!)

pygments/lexers/markup.py Outdated Show resolved Hide resolved
pygments/lexers/markup.py Outdated Show resolved Hide resolved
pygments/lexers/markup.py Outdated Show resolved Hide resolved
@MaxGyver83
Copy link
Contributor Author

@Anteru : Thanks for your review. I hope everything is okay now. Just tell me if you need further changes.

@MaxGyver83 MaxGyver83 requested a review from Anteru April 26, 2020 07:15
@MaxGyver83
Copy link
Contributor Author

@Anteru : Can this PR be merged, please?

@Anteru Anteru added this to the 2.7 milestone May 24, 2020
@Anteru Anteru merged commit 7c46c91 into pygments:master May 24, 2020
@MaxGyver83
Copy link
Contributor Author

Thank you! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants