Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix closing tag for unnamed blocks on MasonLexer #1592

Merged
merged 1 commit into from Nov 8, 2020

Conversation

@gandarez
Copy link
Contributor

@gandarez gandarez commented Nov 6, 2020

The regex for unnamed blocks seems to be wrong defined. According to the official documentation all unnamed blocks including class/doc/init must be ended by a </%class> and not by </%class%> and subsequently.

Example here:
https://metacpan.org/pod/distribution/Mason/lib/Mason/Manual/Intro.pod#Email-generator-(from-script)

@Anteru
Copy link
Collaborator

@Anteru Anteru commented Nov 7, 2020

Good catch and thanks for the contribution! Could you please add a small unit test for this to make sure it won't regress?

@Anteru Anteru added this to the 2.7.3 milestone Nov 7, 2020
@gandarez
Copy link
Contributor Author

@gandarez gandarez commented Nov 7, 2020

@Anteru unit test added as required.

@Anteru Anteru merged commit f4343b7 into pygments:master Nov 8, 2020
13 checks passed
@Anteru
Copy link
Collaborator

@Anteru Anteru commented Nov 8, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants