Add lexer and style for LilyPond #1845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemzwerg
reviewed
Jun 23, 2021
GNU LilyPond is a text-based music typesetter. Because its concepts are completely different from programming languages, this adds a special-purpose to highlight the special tokens. The SchemeLexer is expanded to gain the ability of detecting when one expression stops. LilyPondLexer subclasses SchemeLexer. Builtins (the most important part) are generated with a script put in external/ (as was already done for Lasso). As part of this change, the CPSALexer is made no longer to inherit from SchemeLexer. The inheritance was unused anyway.
|
This is now ready for review. |
|
Is there anything I can do to help this PR move forward? |
|
No, I just need to find some time to review it :/ |
|
@Anteru Gentle ping? |
|
It's on my radar, just busy with other stuff right now -- sorry this is taking that long :( |
|
Finally got around to this. Merged, thanks! |
|
Thank you!! |
|
@Anteru Unfortunately it seems that this PR has broken some checks that have been added in the meantime. I'm on it and will submit a PR very soon. |
|
I think 2d831c1 fixes the last issues. |
|
Yeah, you were faster than me :-) Thanks! |
|
Ok, I still see two quirks:
|
|
Oh right, the style gallery -- good catch. I think an "exclude" attribute would be indeed the best solution. Could you please prepare a PR for both issues? |
|
Will do. |
This was referenced Nov 21, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GNU LilyPond is a text-based music typesetter. Because its concepts
are completely different from programming languages, this adds
a special-purpose to highlight the special tokens.
The SchemeLexer is expanded to gain the ability of detecting when
one expression stops. LilyPondLexer subclasses SchemeLexer.
Builtins (the most important part) are generated with a script
put in external/ (as was already done for Lasso).
As part of this change, the CPSALexer is made no longer to
inherit from SchemeLexer. The inheritance was unused anyway.