Java: fix lexing of 'record' soft keyword #2018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor the Java lexer to treat `record` as a soft keyword. Previously, the lexer assumed record is a reserved word, even though it is a soft keyword which can be used as a variable name. This refactor lexes record as a keyword only if it appears at the beggining of the line, with some potential other keywords like public and private preceding it.
|
Thanks a lot for looking into this at such short notice! I think we'll get a 2.11.2 release out with that soon. Could you please check the lint issue though so I can merge this? |
|
Lint issue fixed. Edit: well now the tests are failing. |
|
Should be all good now :) |
|
Perfect, merged as well. Thanks again for looking at this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the Java lexer to treat
recordas a soft keyword. Fixes #2016.Previously, the lexer assumed record is a reserved word, even though
it is a soft keyword which can be used as a variable name. This meant
that if pygments tried to highlight Java code like
int record = 1(assignment to a variable named record) an error token would be produced.
This refactor lexes record as a keyword only if it appears at the
beginning of the line, with some potential other keywords like public
and private preceding it.
I am not a Java expert at all, but after reading the JEP for records, I think this
covers all cases.