Terraform: Fix class name lexing #2097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `blockname` state did not have a `#pop` after it's only rule, which caused outputting errors in pygments#2094. Instead of adding a `#pop`, I merged the `blockname` state with the rule that uses it, to achieve the exact same lexing logic, but without another state in the lexer.
amitkummer
force-pushed
the
terraform-comment
branch
from
94349b6
to
0f047f4
Compare
Anteru
added
the
changelog-update
|
Merged, thanks a lot! |
Anteru
removed
the
changelog-update
|
Curious if there's a date for the next release? Would like to see if this also fixes the basic HCL syntax issue reported in #1353 ... |
|
It should be any moment now, I'm just having trouble finding some time to push it across the finish line. |
|
That did the trick, thanks @Anteru! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2094.
The
blocknamestate did not have a#popafter it's only rule, which caused outputting errors in #2094.Instead of adding a
#pop, I merged theblocknamestate with the rule that uses it, to achieve the exact same lexing logic, but without another state in the lexer.