Adding MIPS Lexer #2228
Merged
Adding MIPS Lexer #2228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanas
reviewed
Sep 13, 2022
|
Thank you for your feedback! I believe I have made all the changes you suggested, and I added the |
jeanas
reviewed
Sep 14, 2022
jeanas
approved these changes
Sep 16, 2022
|
LGTM, however you now need to rerun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello all! I'm hoping to add a MIPS Assembly lexer. I followed the documentation on creating a lexer to the best of my ability, but please let me know if anything needs to be changed.
make testsran without issue; three were skipped and the rest passed.