Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add func lexer #2232

Merged
merged 8 commits into from
Sep 17, 2022
Merged

Add func lexer #2232

merged 8 commits into from
Sep 17, 2022

Conversation

dvlkv
Copy link
Contributor

@dvlkv dvlkv commented Sep 14, 2022

This PR adds .func and .fc lexer, TON blockchain main smartcontract development langauge.

jeanas
jeanas requested changes Sep 14, 2022
View reviewed changes
Copy link
Contributor

@jeanas jeanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't reviewed this deeply yet, but my first comment is: please add some tests.

sobolevn
sobolevn reviewed Sep 14, 2022
View reviewed changes
Copy link
Contributor

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think: do you need a separate Punctuation group?

pygments/lexers/func.py Outdated Show resolved Hide resolved
pygments/lexers/func.py Outdated Show resolved Hide resolved
pygments/lexers/func.py Outdated Show resolved Hide resolved
pygments/lexers/func.py Outdated Show resolved Hide resolved
pygments/lexers/func.py Outdated Show resolved Hide resolved
pygments/lexers/func.py Outdated Show resolved Hide resolved
@dvlkv
Copy link
Contributor Author

dvlkv commented Sep 14, 2022

@sobolevn Thank you for your review. Check my edits, now looks better. Also, I've thought that Punctuation group would't be redundant.

@dvlkv
Copy link
Contributor Author

dvlkv commented Sep 15, 2022

@jean-abou-samra added some tests

@dvlkv dvlkv requested review from jeanas and sobolevn and removed request for jeanas and sobolevn September 15, 2022 00:28
sobolevn
sobolevn reviewed Sep 15, 2022
View reviewed changes
pygments/lexers/func.py Outdated Show resolved Hide resolved
pygments/lexers/func.py Show resolved Hide resolved
@dvlkv
Copy link
Contributor Author

dvlkv commented Sep 16, 2022

@jean-abou-samra fixed all linters, pls rerun pipelines

jeanas
jeanas approved these changes Sep 16, 2022
View reviewed changes
Copy link
Contributor

@jeanas jeanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sobolevn for reviewing this, very much appreciated! I have nothing more to say.

jeanas
jeanas reviewed Sep 16, 2022
View reviewed changes
tests/test_func.py Outdated Show resolved Hide resolved
@jeanas jeanas merged commit fcfcdcd into pygments:master Sep 17, 2022
@jeanas
Copy link
Contributor

jeanas commented Sep 17, 2022

LGTM.

@Hiyorimi Hiyorimi mentioned this pull request Sep 22, 2022
Closed
@Anteru Anteru added this to the 2.14.0 milestone Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn left review comments

@jeanas jeanas jeanas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.14.0
Development

Successfully merging this pull request may close these issues.
4 participants
@dvlkv @jeanas @sobolevn @Anteru