New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Luau #2605
Merged
Merged
Add Luau #2605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While it can technically act as a variable, I decided that continue should always highlight as a keyword, similar to other lexers. The old behavior wouldn't have always worked anyways.
jeanas
reviewed
Dec 4, 2023
Anteru
requested changes
Dec 5, 2023
Anteru
requested changes
Dec 30, 2023
@@ -163,6 +163,321 @@ def get_tokens_unprocessed(self, text): | |||
continue | |||
yield index, token, value | |||
|
|||
def _luau_make_expression(should_pop, _s): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add a comment as to what this function does and rename _s
to something more readable?
Anteru
added
the
changelog-update
Items which need to get mentioned in the changelog
label
Feb 17, 2024
Anteru
removed
the
changelog-update
Items which need to get mentioned in the changelog
label
Apr 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for Luau, a superset of Lua 5.1 created by Roblox. https://luau-lang.org/
Similar to the Lua lexer, this lexer provides options to control the builtins that it highlights. Additionally, due to Luau originating from Roblox and it still being the main usage, an option to automatically include Roblox builtins is included.