Add a __class_getitem__ to Formatter #2665
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simpler and less disruptive alternative to #2081.
The type stubs in typeshed distinguish between formatters that output strings and bytes. In type annotations, these are distinguished with
Formatter[str]
andFormatter[bytes]
. For the most part, this works fine without any changes in pygments: users just tell Python to not evaluate type annotations at runtime (withfrom __future__ import annotations
), and then aFormatter[str]
type annotation won't cause an error even though subscripting theFormatter
class wouldn't work.But one special case happens when you try to subclass a
Formatter
. For that, you actually need to specify a class, not a type annotation. So users end up with:With this PR, this simplifies to: