-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated stub with imbedded documentation #236
Conversation
Imbedded documentation in the stub, tested with pylance.
Uniformized the docstrings convention for consistency
Interesting :) But tests are failing |
Will this fix #225?
should be simple to make it pass :) |
Hopefully this should past tests, I corrected forward references
I updated the stub to correct for forward references, this should pass the test, it did locally for me |
I'm not too sure I understand the assertion error with typing |
I copied the constants directly from the original __init__.pyi, where the tests passed. So It should pass now?
This comment has been minimized.
This comment has been minimized.
I remodeled the file based on the original. The only major differences between the two are the docstrings now. If the original file passed the test, this should do as well.
I remodeled the file based on the original. The only major differences between the two are the docstrings and the order of some functions within classes, which shouldn't influence the test. If the original file passed the test, this should do as well. |
Run all the Github actions for test on my side, passes all tests with the latest commit! |
Thanks.
|
Yes, so
|
Oh and to add more info on why I made the docstring that way is that pylance would only correctly display code snippets if preceded by |
I see, thanks. It's a start, but we should try to avoid duplication so the best way forward is probably to use sphinx-autodoc with napoleon and hope pylance supports the standard docstring formats at some point. |
Irrc, it's already supported? |
Realise this is merged already - but we should integrate linters for documentation too, to enforce whatever standards we decide on. |
I've somewhat broken the vscode experience with this by switching back to rst in #252 I hope that someday vscode will figure out a way to parse reST, or at least adds some syntax highlighting: microsoft/pylance-release#2002 I hope you understand. |
Imbedded documentation in the stub, tested with pylance.