Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Test on Python 3.7 #164

Merged
merged 4 commits into from
Aug 3, 2018
Merged

WIP: Test on Python 3.7 #164

merged 4 commits into from
Aug 3, 2018

Conversation

jarrodmillman
Copy link
Contributor

See networkx/networkx#3056

Xenial is not officially supported yet.

See travis-ci/travis-ci#9815

@coveralls
Copy link

coveralls commented Aug 2, 2018

Coverage Status

Coverage increased (+0.5%) to 81.918% when pulling 34c3cce on jarrodmillman:py37 into 36120f2 on pygraphviz:master.

@dschult
Copy link
Contributor

dschult commented Aug 3, 2018

OK... This seems to pass the python 3.7 tests now.
It was all about StopIteration and being more explicit about how to handle that event.

jarrodmillman added a commit to jarrodmillman/networkx that referenced this pull request Aug 3, 2018
@jarrodmillman
Copy link
Contributor Author

@dschult We are still getting an error in the networkx tests:

test_agraph.TestAGraph.test_directed ... ok
test_agraph.TestAGraph.test_from_agraph_name ... ok
test_agraph.TestAGraph.test_graph_with_reserved_keywords ... ok
test_agraph.TestAGraph.test_multi_directed ... ok
test_agraph.TestAGraph.test_multi_undirected ... ok
test_agraph.TestAGraph.test_round_trip ... ok
test_agraph.TestAGraph.test_undirected ... ok
test_agraph.TestAGraph.test_view_pygraphviz ... Unescaped left brace in regex is deprecated, passed through in regex; marked by <-- HERE in m/%{ <-- HERE (.*?)}/ at /usr/bin/run-mailcap line 528.
Error: no "view" rule for type "image/png" passed its test case
       (for more information, add "--debug=1" on the command line)
�[?1049h�[H�[2J�[40;1HHit�[Cany�[Ckey�[Cto�[Cquit�[Cw3m:�[40;25H

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received

The build has been terminated

I changed the pygraphviz line in the requirements file to

 git+https://github.com/jarrodmillman/pygraphviz@py37 

and reran the tests

https://travis-ci.org/networkx/networkx/builds/411808235

This fixed all the errors (we were getting) on Python 3.7 except the final one

test_agraph.TestAGraph.test_view_pygraphviz ... Unescaped left brace in regex is deprecated, passed through in regex; marked by <-- HERE in m/%{ <-- HERE (.*?)}/ at /usr/bin/run-mailcap line 528.
Error: no "view" rule for type "image/png" passed its test case
       (for more information, add "--debug=1" on the command line)

@dschult
Copy link
Contributor

dschult commented Aug 3, 2018

I'm not sure what the error message means on that last error... but that is where I get lots of warning messages from fontconfig when I run the tests on my machine.

Also, the Travis-CI log seems to indicate that it hangs at that point in the tests and never continues to the next test: test_agraph.TestAGraph.test_view_pygraphviz_edgelabel

Any ideas on why it would hang at that point? It seems to be wanting to "view" the picture instead of writing it to a file.

@jarrodmillman
Copy link
Contributor Author

This last error looks like it was an issue with xdg-open on xenial. Here is someone talking about a similar problem: https://askubuntu.com/questions/779717/xdg-open-stopped-working-since-16-04-upgrade

I will fix this in networkx.

@jarrodmillman
Copy link
Contributor Author

This seems to supercede #146.

@dschult dschult merged commit 0e20f3e into pygraphviz:master Aug 3, 2018
jarrodmillman added a commit to jarrodmillman/networkx that referenced this pull request Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants