Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace raise StopIteration with return #146

Closed
wants to merge 1 commit into from
Closed

Replace raise StopIteration with return #146

wants to merge 1 commit into from

Conversation

leviable
Copy link

@leviable leviable commented Mar 9, 2018 •
edited

  • Raising StopIteration was deprecated in python 3.5, and throws
    warnings when used
  • Replace raise StopIteration with canonical return
  • See PEP 479

@leviable
Replace raise StopIteration with return
1a4357d 
 - Raising StopIteration was deprecated in python 3.5, and throws
   warnings when used
 - Replace `raise StopIteration` with canonical `return`
@coveralls
Copy link

coveralls commented Mar 9, 2018 •
edited

Coverage Status

Coverage remained the same at 81.39% when pulling 1a4357d on levi-rs:fix-deprecated-stop-iter into 36120f2 on pygraphviz:master.

@aleneum aleneum mentioned this pull request Aug 1, 2018
Closed
@jarrodmillman jarrodmillman mentioned this pull request Aug 3, 2018
Merged
@dschult
Copy link
Contributor

dschult commented Aug 3, 2018

superceded by #164
It turns out we needed to also check for StopIteration being created in the C code. so we can catch it before returning.

Thanks for this!

@dschult dschult closed this Aug 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@leviable @coveralls @dschult