Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure define_macros remains a list on Windows #412

Merged
merged 1 commit into from
May 31, 2022
Merged

Ensure define_macros remains a list on Windows #412

merged 1 commit into from
May 31, 2022

Conversation

nehaljwani
Copy link
Contributor

@nehaljwani nehaljwani commented May 29, 2022 •
edited by rossbar

Faced issues building pygraphviz with Graphviz 3+, since specifying /DGVDLL is now mandatory.

>>> define_macros = []
>>> define_macros = define_macros.append(("GVDLL", None))
>>> print(define_macros)
None

Closes #408

nehaljwani added a commit to regro-cf-autotick-bot/pygraphviz-feedstock that referenced this pull request May 29, 2022
@nehaljwani
Add patch to make sure /DGVDLL is set on Windows
0b99631 
Graphviz v3 made it compulsory for consumers of shared libraries on
Windows to set the GVDLL macro to be able to use them successfully

xref: https://gitlab.com/graphviz/graphviz/-/commit/59aeebd8
xref: pygraphviz/pygraphviz#412
rossbar
rossbar approved these changes May 31, 2022
View reviewed changes
Copy link
Contributor

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch @nehaljwani . This looks like it will fix #408 as well.

@nehaljwani
Copy link
Contributor Author

Yes, #408 is exactly what I was facing.

@rossbar rossbar merged commit 3053c66 into pygraphviz:main May 31, 2022
@jarrodmillman jarrodmillman added this to the 1.10 milestone Aug 12, 2022
rossbar pushed a commit to rossbar/pygraphviz that referenced this pull request Oct 3, 2023
@nehaljwani @rossbar
Ensure define_macros remains a list on Windows (pygraphviz#412)
71e0205 
Fixes issue building with graphviz 3.0, which requires the GVDLL symbol
to be defined.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rossbar rossbar rossbar approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
1.10
Development

Successfully merging this pull request may close these issues.

Fails to compile with graphviz 3.0.0
3 participants
@nehaljwani @rossbar @jarrodmillman