Upgrade/v1.82 #192
Upgrade/v1.82 #192
Conversation
…onfigResizeWindowsFromEdges renamed to ConfigWindowsResizeFromEdges
|
OH MY GOD. That's huge! And great! How did you manage to do all of that? Last time I was attempting the update I have realized how many flags there are and how often they change I had to create some custom tooling to automate that stuff. |
|
I'm totally loaded with work at the moment but I quit my current job next week so finally will have more time to do all the reviews, merges and releases. Anyway, don't stress about missing functions. We never had 100% feature parity (imgui has HUGE API). Just tell me when you're ready and we merge it. Later we can do incremental updates. |
I saw your scripts but was not really sure of how to use them properly. I initially wanted to code my own and even started to list all features that such a script should have to compare versions and propose updates, but I figured out that I needed to go manually through the entire process once before being able to automatize it. Maybe I should regroup my notes and take the time to understand your scripts to plan the development of a generic tool that we could use after each update of ImGui. A semi-automated process that checks changes between ImGui versions and proposes the modifications to do would be of great help for future upgrades. |
…egacy but assert if different than 1 like ImGui does
…acy but assert if different than 1 like ImGui does
… and SetTabItemClosed() + doc
|
@KinoxKlark BTW sorry for cancelling your builds on travis. I'm working on a new Appveyor pipeline for macOS builds because the old one on travis became unmanageable. Appveyor isn't perfect but simply works better and faster. Maybe will migrate the manylinux1 build to Appveyor too. When I get it done I'll ask you to rebase on master. OK? |
…wData::FramebufferScale
wrap str in _bytes()
Upgraded demos to function on 1.82
…custom window bug
…into upgrade/v1.79
|
Hello! I have great interest in this PR, notably for what @hinxx is working on (I'd love to have implot bindings). Do we have any updates on what's next? Are you all just waiting for @swistakm to give access to the repository to be able to merge that PR upstream, or does the PR still require some work? |
|
Hello, glad to hear about your interest in this PR ! Unfortunately, I have been loaded with work for the end of the semester at my university, I had to do a pause to focus on other projects and I won't be able to continue this until next month. As for now, this PR is functioning but requires more testing to be used as a release. Many minor functionalities can be added (e.g. mapping of functions), but pyimgui have never been fully mapped thus what has already be done could be enough for now. As you mentioned @hinxx was working on an external binding of implot, to this respect we discussed how to share the cpp imgui lib to external modules here: KinoxKlark#2 . I think this is temporarily in pause too but definitely a cool project ^^ For the next, we are waiting on @swistakm to be able to move forward, although there is no clear plan of what to do. There is also a new release of imgui (v1.83) with new functionalities to map but I don't know if we should do it here or start a new PR. |
|
I'm pretty much in the same situation with regards to lack of time in the coming weeks. I still do have interested in going forward with pyimplot and have something that could be tested and evaluated right now but needs a bit of coordination to make us all comfortable in using it. I see myself devoting more time to this after summer vacation is over. |
|
fwiw we're using the branch in a small internal app, and haven't had any problems with it |
|
Hello, I will finally have more time to invest in this project! I am not really sure about how we should continue here. In the absence of @swistakm I don't think there is much we can do concerning the official release. For now, I think the best we can do is to make this pr as robust as possible so that people interested in a stable branch with more up-to-date imgui functionalities could use it by manual installation. I will need little time to go on stuff that I have missed the last few months. I would appreciate some insight about the following matters and how we should deal with them:
I may have forgotten some important stuff, feel free to add to that list. My hope is that we would be able to maintain from this pr a good enough version to be used by anyone who needs it. And maybe one-day @swistakm would manage to merge it and drop a stable release quickly. Thank's in advance, looking forward to your advice! |
|
To me it feels like in order to keep this project alive and healthy we really need an official place to have it. Incremental changes to a PR, or several pending PRs adding all new functionality is not a good base for welcoming new members of a community or maintaining a stable code base. Obviously what would be optimal is to have @swistakm back to help maintaining the project or to give admin rights to the ones that are the most involved in maintaining that project already. (I guess @KinoxKlark and @hinxx ? Not sure who I'm missing) This way everything could be stabilized properly, merged to master and then we could fix CI issues and publish to PyPI. It would also allow merging further fixes easily, maintain the documentation and so on In the meantime, I guess what could be best is doing the same in a fork, like maybe yours @KinoxKlark? |
|
I have been working on my own projects with this PR for a while now and I can vouch for it as well. I made UI focused app and other with OpenGL render interactions via SDL and didn't get into any troubles. Only issue I found so far it is a little keyboard input issue. :) |
|
Hey all! I really apologize for not being responsive in this project. I hoped that once I will finish my book I will have some time, but it turns out I will probably be eternally busy and unable to properly support such projects. The least I can do is to handverthe project to someone (or group of people). I may be able to support project with other resource but probably won't have time for active development anymore. I know that we had this conversation before and we didn't decide on anything but now I think it is the only solution. Probably that's simply not a thing that can be easily discussed asynchronously via GitHub issues. Best if we could meet online (e.g. via Zoom) and discuss this live. @KinoxKlark, @TTimo, @hinxx: I was thinking mostly about three of you but anyone who want's to actively participate and has some spare time is free to join. If you are interested please drop me an email (address is in my Github). If you give me your time availability ( in UTC) I will setup a call where we can finally meet and discuss how to move forward. Best if we could meet over weekend because next week I leave my country for a couple of days. |
|
Might I suggest to transfer the repo to an organization, where multiple people can join in on the fun? or if you want to keep the repo under your name, make a few people able to add / remove participants on this repo. |
|
@learn-more organization of course |
|
Thanks all for your answers! Nice to hear from you @swistakm. I'll drop you a mail to organize a meeting, it seems more appropriate indeed. I accept to take more responsibilities if it is needed to move forward. I agree with @learn-more, I think we need to make sure multiple people have access and can manage the project in the case where one of us can't be present. @Froyok, thank you a lot for your feedback. I'll check on that issue as soon as possible ;) |
|
Hey everyone, You may have noticed that the project is now an organization one. Moreover, I now have admin right to the repo (and organization) thanks to @swistakm. I opened a discussion about the future and management of the project here: #237. I hope to gather your opinions there. We will be able to move forward with the project and prepare future releases! There are still details to manage about the succession (like PyPi access for distribution). Those will be dealt with as we go along. I will take some vacation in the coming week so I won't be always present for the development. I will still try to come regularly for the discussion. Feel free to comments in #237 and gives any insights/advice. Thanks in advance! |
|
Finally! I have merged this PR to a dev branch in order to prepare the next major release. (https://github.com/pyimgui/pyimgui/tree/dev/version-2.0) I will keep my fork and this branch for a time for those who use it in their project. |
I started to upgrade imgui from v1.65 to v1.79
It is not finished yet, there is a lot of new unimplemented functions, but it should pass tests and be usable with the new ImGui code. I quickly tested the imgui.show_test_window(), and new features seem to work fine. I am willing to put some time into mapping functions to complete the upgrade. Feedback would be great :)