Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1. change imgui to master branch && update setup.py 2. fix: example cannot close custom window bug 3. fix: pygame key_map over imgui max value 4. fix: some compile error #224

Closed
wants to merge 1 commit into from

Conversation

gqw
Copy link

@gqw gqw commented Mar 31, 2021

  1. change imgui to master branch && update setup.py
  2. fix: example cannot close custom window bug
  3. fix: pygame key_map over imgui max value
  4. fix: some compile error

2. fix: example cannot close custom window bug
3. fix: pygame key_map over imgui max value
4. fix: some compile error
@KinoxKlark
Copy link
Member

This is great thanks! Be aware of #192 where an update to the latest imgui release is planned and most of the work has already be done. I will look at your fixes and merge new ones when I'll have some spare time (probably next week)!

@gqw
Copy link
Author

gqw commented Apr 2, 2021

thanks for your great work!!!

KinoxKlark added a commit to KinoxKlark/pyimgui that referenced this pull request Apr 5, 2021
@KinoxKlark
Copy link
Member

Hey! I merged your fix for the closing button of the example window in #192: bd532d5. I did go over the other changes but I think everything else was already ok. Feel free to test it and tell me if I forgot anything. Thanks again!

@KinoxKlark
Copy link
Member

Hello, sorry for the late management of your push request, I only recently obtained write access to the repo to manage it instead of its original owner.

As said in my previous message, your changes have been merge with the upcoming upgrade to a more recent version of dear imgui in my branch #192.

I am currently merging every PR that may not request the upgrade to release a minor version. The next major release will contain the upgrade and may break some things. Since both releases will (I hope) succeed rapidly and since these changes are already part of the upgrade I don't think this needs to be merged now and I will close this PR. Let me know if you think this is a mistake and if I have missed anything important.

Best

@KinoxKlark KinoxKlark closed this Aug 9, 2021
@KinoxKlark KinoxKlark added the release pending Merged but still needs official release label Aug 9, 2021
@KinoxKlark KinoxKlark removed the release pending Merged but still needs official release label Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants