Pthom/master fixes #276
Merged
Pthom/master fixes #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 is enough to get antialiasing, and on two of my machines (Ubuntu 20.04- docker, and Ubuntu desktop 20.04), the initialization failed with the message (when running `SDL_GL_CreateContext(window)`) Error: Cannot create OpenGL Context! SDL Error: Invalid window gl_context = SDL_GL_CreateContext(window)
|
Note: the CI failure is due to sphinx (I did not change anything in the doc or its configuration) |
|
This looks reasonable to me. I rebased your PR to the Here for reference your other PR which develops a little bit more on the sdl multisampling buffer: #277 Thanks! Edit: And don't worry about CI failure, I think I broke something in the config, I'll look at it when I'll found time! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two simple corrections in the examples.
The sdl example modification may be important for new users, since I suspect I more users might encounter this issue.