Pthom/docking fixes #277
Merged
Pthom/docking fixes #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
io.fonts.add_font_from_file_ttf now takes 4 params: the third param (font_config) was missing
As was done in test_begin_end_context_managers, the context is destroyed / recreated for each test: ```` @pytest.fixture def context(): ctx = imgui.get_current_context() if ctx is not None: imgui.destroy_context(ctx) ctx = imgui.create_context() return ctx ```` Otherwise, we get this error: ```` > ctx = imgui.create_context() test_graphics_mem_safety.py:11: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ > ??? E imgui.core.ImGuiError: ImGui assertion error (FindSettingsHandler(handler->TypeName) == NULL) at imgui-cpp/imgui.cpp:12311 imgui/core.pyx:11676: ImGuiError ````
8 is enough to get antialiasing, and on two of my machines (Ubuntu 20.04- docker, and Ubuntu desktop 20.04), the initialization failed with the message (when running `SDL_GL_CreateContext(window)`) Error: Cannot create OpenGL Context! SDL Error: Invalid window gl_context = SDL_GL_CreateContext(window)
|
Note: here also, the CI failure is in the doc generation (which I did not touch) |
Merged
KinoxKlark
approved these changes
Apr 21, 2022
|
Ok for me, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fb5c692 : sdl example: SDL_GL_MULTISAMPLEBUFFERS=8 instead of 16:
8 is enough to get antialiasing, and on two of my machines (Ubuntu 20.04- docker, and Ubuntu desktop 20.04),
the initialization failed with the message (when running
SDL_GL_CreateContext(window))ec81800 :
Correct tests graphics_mem_safety and gui_style: create/destroy context
As was done in test_begin_end_context_managers, the context is destroyed / recreated for
each test.
Note: the tests pass without this modification, but it will soon become required when updating imgui-cpp (it was required for imgui-cpp docking branch, as of may 2022)
1924985 : correct doc/examples/fonts.py