Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a hook for pingouin to collect data files. #292

Merged
merged 4 commits into from
Aug 19, 2021
Merged

Add a hook for pingouin to collect data files. #292

merged 4 commits into from
Aug 19, 2021

Conversation

JonMrowczynski
Copy link
Contributor

No description provided.

@JonMrowczynski JonMrowczynski requested review from a team and rokm and removed request for a team August 17, 2021 21:19
@bwoodsend
Copy link
Member

Are users really likely to need those files? The csv files look like test/example datasets (although they are pretty tiny so they don't waste much space if they're not needed).

@JonMrowczynski
Copy link
Contributor Author

JonMrowczynski commented Aug 18, 2021 via email

@bwoodsend
Copy link
Member

bwoodsend commented Aug 18, 2021

I've tried it out and it looks like only the pingouin/datasets/datasets.csv file is needed but it's much easier just to collect everything like you already are so I'll accept this for now. Can you give us a test and add pingouin to the requirements file?

@JonMrowczynski
Copy link
Contributor Author

JonMrowczynski commented Aug 19, 2021 via email

@bwoodsend bwoodsend merged commit 9266fc6 into pyinstaller:master Aug 19, 2021
@bwoodsend
Copy link
Member

Thanks @JonMrowczynski!

@JonMrowczynski
Copy link
Contributor Author

JonMrowczynski commented Aug 19, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants