Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding hooks for google cloud & google api modules #3251

Merged
merged 1 commit into from
Nov 8, 2019

Conversation

bayesfactor
Copy link
Contributor

In my build, I found a runtime error unless I included these hook files before build.

@htgoebel htgoebel added the area:hooks Caused by or effecting some hook label Feb 27, 2018
@htgoebel
Copy link
Member

This hook is for "google.api", but includes meta-data from "google-api-core". Thus should'nt this be a hook for e.g. "google.api.core"?

@htgoebel
Copy link
Member

@bayesfactor Would you please answer the questions so we can proceed with this pull-request? Thanks.

@bayesfactor
Copy link
Contributor Author

I admit I'm no expert, so I tested both ways.
with google-api-core, the project builds and runs.
with google.api.core, I get an error on build:
pkg_resources.DistributionNotFound: The 'google.api.core' distribution was not found and is required by the application.

@htgoebel
Copy link
Member

htgoebel commented Jun 6, 2019

@bayesfactor Sorry for not commint back on this for so long. I'd like to merge it. For this please

@htgoebel htgoebel added the pr:changelog-entry Changelog entry missing or needs revision label Jun 6, 2019
@htgoebel htgoebel self-assigned this Jun 6, 2019
@bayesfactor
Copy link
Contributor Author

I created the entry in the changelog: news/3251.bugfix.rst

I hope this is correct

@htgoebel
Copy link
Member

htgoebel commented Jul 4, 2019

@bayesfactor There is still only one file in the pull-request - no changelog entry. Also this needs to go into the "hooks" section, as the manual states.

@htgoebel
Copy link
Member

htgoebel commented Nov 8, 2019

@bayesfactor Pinging. The changelog entry is still missing. Please add one, so I can merge. Thanks.

@htgoebel htgoebel merged commit f86170c into pyinstaller:develop Nov 8, 2019
@htgoebel htgoebel removed the pr:changelog-entry Changelog entry missing or needs revision label Nov 8, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area:hooks Caused by or effecting some hook
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants