-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding hooks for google cloud & google api modules #3251
Conversation
This hook is for "google.api", but includes meta-data from "google-api-core". Thus should'nt this be a hook for e.g. "google.api.core"? |
@bayesfactor Would you please answer the questions so we can proceed with this pull-request? Thanks. |
I admit I'm no expert, so I tested both ways. |
@bayesfactor Sorry for not commint back on this for so long. I'd like to merge it. For this please
|
I created the entry in the changelog: news/3251.bugfix.rst I hope this is correct |
@bayesfactor There is still only one file in the pull-request - no changelog entry. Also this needs to go into the "hooks" section, as the manual states. |
@bayesfactor Pinging. The changelog entry is still missing. Please add one, so I can merge. Thanks. |
In my build, I found a runtime error unless I included these hook files before build.