New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UCRT warnings on win10 #3736
UCRT warnings on win10 #3736
Conversation
Thank you for you pull-request. Please move the first commit into a separate pull-request since it is unrelated, much more complex and need separate review. Hint: Please reword your commit messages to comply to our Commit Message Rules. You also need to submit a changelog entry so our users can learn about your change. (This is new since a few weeks now.) Also you should base your commit on the latest development HEAD. You are currently basing on a commit which is more then one year old. When updating a pull-request, you can simply (force) push the updated branch to github again. This will automatically update the pull-request (which follows the branch, not the commit). So you do not need to close the pull-request and open a new one. This also has the benefit that the discussion history is kept. For detailed instructions please read Updating a Pull-Request in the manual. Thanks. |
Oh, I just see you already have two pull-requests. Please base the second on the |
Something went wrong with this pull-request. Now it does not contains anything related UCRT to. |
I rebased on current develop and force-pushed to ucrt_win10 branch. |
How did you rebase? This should work:
|
Common process, yeah. I would say I did exactly these steps but evidently I must have done something else along the way. |
4af90f4
to
fa82207
Compare
These files do not exist on Windows 10 on purpose (see issue pyinstaller#1566). [skip travis] no need to test on non-windows platforms
Thanks for the pull-request. I merged it just a minute ago. |
bindepend: don't generate warnings regarding missing UCRT dependencies on windows 10 as these files do not exist on purpose (see issue #1566)