depend: exempt OSX system Tcl/Tk libs from relative path rewrite #5172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The older python.org builds that use system Tcl/Tk framework have their _tkinter.cpython-*-darwin.so library linked against /Library/Frameworks/Tcl.framework/Versions/8.5/Tcl and /Library/Frameworks/Tk.framework/Versions/8.5/Tk, although the actual frameworks are located in /System/Library/Frameworks. Therefore, we fail to recognize these libraries as system ones, and rewrite their paths with relative ones. The resulting program fails to run due to missing libraries (as we do not bundle them). To fix the issue, these two libraries need to be explicitly exempted from the path overwrite.
Legorooj
approved these changes
Sep 28, 2020
This was referenced Oct 2, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The older python.org builds that use system Tcl/Tk framework have their
_tkinter.cpython-*-darwin.solibrary linked against/Library/Frameworks/Tcl.framework/Versions/8.5/Tcland/Library/Frameworks/Tk.framework/Versions/8.5/Tk, although the actual frameworks are located in/System/Library/Frameworks.Therefore, we fail to recognize these libraries as system ones, and rewrite their paths with relative ones. The resulting program fails to run due to missing libraries (as we do not bundle them).
To fix the issue, these two libraries need to be explicitly exempted from the path overwrite.