Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

depend: exempt OSX system Tcl/Tk libs from relative path rewrite #5172

Merged
merged 2 commits into from
Sep 28, 2020
Merged

depend: exempt OSX system Tcl/Tk libs from relative path rewrite #5172

merged 2 commits into from
Sep 28, 2020

Commits on Sep 15, 2020

  1. depend: exempt OSX system Tcl/Tk libs from relative path rewrite 

    The older python.org builds that use system Tcl/Tk framework have
their _tkinter.cpython-*-darwin.so library linked against
/Library/Frameworks/Tcl.framework/Versions/8.5/Tcl and
/Library/Frameworks/Tk.framework/Versions/8.5/Tk, although the
actual frameworks are located in /System/Library/Frameworks.

Therefore, we fail to recognize these libraries as system ones,
and rewrite their paths with relative ones. The resulting program
fails to run due to missing libraries (as we do not bundle them).

To fix the issue, these two libraries need to be explicitly
exempted from the path overwrite.
    @rokm
    rokm committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    641b4be View commit details
    Browse the repository at this point in the history

  2. Add news fragment for the PR [skip-ci]

    @rokm
    rokm committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    d4e899b View commit details
    Browse the repository at this point in the history