Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hooks: Fix
sysconfig
anddistutils.sysconfig
. #5218Hooks: Fix
sysconfig
anddistutils.sysconfig
. #5218Changes from all commits
1c153f7
b5be6af
ea3a2e1
5806950
1557991
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I've seen this, I ask myself: This is not testing anything?!
Please add a comment like "rasies if files are not round, see doc-string".
Please also state how/whether this tests for both config.h and Makefile.
Anyway, please rethink this. The old test-script did test qite explicitly on these two files. I could imaging the Python implementation to be changed, and get_config_vars() returning some built-in data-structure.