archive: fix TOC entry alignment in PKG/CArchive #7571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The archive writers clean-up in pyinstaller#7518 introduced a subtle bug that causes incorrect padding of TOC entries that require no padding; such entries receive padding of the previously-processed entry. This in turn breaks 16-byte alignment of the TOC entries, causing bus error when running executables on platforms with stricter data alignment requirements, for example armhf (32-bit Raspbian OS).
Legorooj
approved these changes
Apr 14, 2023
|
Think I'll do a patch release for this one. It sounds pretty nasty. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The archive writers clean-up in #7518 introduced a subtle bug that causes incorrect padding of TOC entries that require no padding; such entries receive padding of the previously-processed entry.
This in turn breaks 16-byte alignment of the TOC entries, causing bus error when running onefile executable on platforms with stricter alignment requirements, for example armhf (32-bit Raspian OS).
Fixes #7566.