Fix relocate osx libraries #7690
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If the .dylib and .so files ended up in Resources, then they were marked as data files (their TOC entries have DATA) during analysis stage. This happens either if you manually add them via Either way, you should look into why the entries are mislabeled during Analysis, instead of adding hard-coded work-arounds to BUNDLE code (nonetheless because I'm currently rewriting that part of code, and all relocation exemptions will be removed). |
|
Thank you for the detailed explanation, also in spacetelescope/jdaviz#1960 ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using codesign on osx fails if .so and .dynlib are not in the right locations. Right now they end on in Resources, but they should go into MacOS.
The same happens for executable, for instance the "plasma-store-server" ends up in Resources, but should also go to MacOS. I am not sure however how to recognize binaries (will they have +x?).