POC: Attempt to package jdaviz in Pyinstaller (take 2) #1960
Conversation
maartenbreddels
requested review from
duytnguyendtn,
rosteen,
javerbukh,
ojustino,
pllim,
kecnry and
bmorris3
as code owners
maartenbreddels
force-pushed
the
pyinstaller_v2
branch
8 times, most recently
from
1cf57af
to
d91826b
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1960 +/- ##
==========================================
- Coverage 91.77% 90.86% -0.91%
==========================================
Files 150 152 +2
Lines 16847 17075 +228
==========================================
+ Hits 15461 15515 +54
- Misses 1386 1560 +174
☔ View full report in Codecov by Sentry. |
maartenbreddels
force-pushed
the
pyinstaller_v2
branch
7 times, most recently
from
5c2eba7
to
37420b5
Compare
There was a problem hiding this comment.
I wonder if there is a way we can incorporate this into CI like https://github.com/astropy/astropy/blob/c5075845d900bc062b633369f228ea8fd89470d6/tox.ini#L153
Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>
Jdaviz Launcher
Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>
There was a problem hiding this comment.
I now have the Github secrets set up for this to run successfully in our repository (see successful run at https://github.com/spacetelescope/jdaviz/actions/runs/5466039021). We'll need follow-up to integrate some of the other recent launcher work, but I think this is good to be merged now and we can open another PR to improve this later.
| def _specviz(): | ||
| _main(config='specviz') | ||
|
|
||
|
|
||
| def _specviz2d(): | ||
| _main(config='specviz2d') | ||
|
|
||
|
|
||
| def _imviz(): | ||
| _main(config='imviz') | ||
|
|
||
|
|
||
| def _cubeviz(): | ||
| _main(config='cubeviz') | ||
|
|
||
|
|
||
| def _mosviz(): | ||
| _main(config='mosviz') |
There was a problem hiding this comment.
@duytnguyendtn do these need to be changed to use layout rather than config after your work?
And @maartenbreddels, are these necessary for the stand-alone to work? I changed the standalone entry point to call main() instead of _imviz(), but I see they are used in setup.cfg although I don't fully understand what those console_scripts entry points are doing there.
There was a problem hiding this comment.
Nope! In the launcher PR, the config arg just translates it to layout if provided:
Lines 146 to 149 in 9427518
There was a problem hiding this comment.
Excellent, got it. I'll just leave this alone then!
…daviz into maarten-pyinstaller_v2
I can't push to #1914 so opening this PR so I can see how CI runs.
Note that I don't have it fully working yet locally, I can't get Voila to render the widgets yet.
Fix #674