Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

building: retry mechanism: enable retry on winerror 110 #8139

Merged
merged 1 commit into from Dec 2, 2023

Conversation

rokm
Copy link
Member

@rokm rokm commented Dec 2, 2023

Add winerror 110 (ERROR_OPEN_FAILED) to the list of permissible error codes for the retry mechanism that attempts to mitigate build failures due to anti-virus program interference.

At the same time, reorganize the exception-checking code by merging all Windows specific code into a single branch. This allows us to re-use _ALLOWED_WINERROR with both pywintypes.error and OSError. With the latter, we now compare the winerror attribute as a fall back after errno comparison.

Closes #8138.

Add winerror 110 (`ERROR_OPEN_FAILED`) to the list of permissible
error codes for the retry mechanism that attempts to mitigate
build failures due to anti-virus program interference.

At the same time, reorganize the exception-checking code by
merging all Windows specific code into a single branch. This allows
us to re-use `_ALLOWED_WINERROR` with both `pywintypes.error` and
`OSError`. With the latter, we now compare the `winerror` attribute
as a fall back after `errno` comparison.
@bwoodsend
Copy link
Member

Is tests/requirements-libraries.txt missing a pin somewhere? Shouldn't these random Qt regressions only occur during PyUp updates?

@rokm
Copy link
Member Author

rokm commented Dec 2, 2023

Is tests/requirements-libraries.txt missing a pin somewhere? Shouldn't these random Qt regressions only occur during PyUp updates?

We're not pinning the -Qt5 / -Qt6 packages of PyQt5/6 (nor the PySide6-Essentials and PySide6-AddOns for PySide6). We used to have the PyQt5-Qt5 and PyQt6-Qt6 pinned at some point, but I removed those when I added additional PyQt packages (PyQtCharts, PyQt6-QtCharts, etc.), because each of those would also need their own -Qt5/-Qt6 package pinned.

Think I'll re-pin those, though, as well as add pins for all other -Qt5/-Qt6 packages. It's going to be ugly, but PyUp should manage...

@rokm rokm merged commit ac7f683 into pyinstaller:develop Dec 2, 2023
8 of 18 checks passed
@rokm rokm deleted the windows-retry-on-winerror-110 branch December 2, 2023 23:16
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[retry mechanism(?)]: "The system cannot open the device or file specified."
2 participants