Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFQ: Default logging at info level #75

Open
mstovenour opened this issue Mar 6, 2021 · 2 comments
Open

RFQ: Default logging at info level #75

mstovenour opened this issue Mar 6, 2021 · 2 comments

Comments

@mstovenour
Copy link
Contributor

I've noticed that in the new library, when running under Home Assistant, the "info" logging level seems to be the same as "warn". I'd like to discuss a proposal to change that behavior before I work out a pull request for the same. Here's my proposal:

  • warn: Very quiet, mostly just success startup and any conditions that might need to be addressed. I think the existing code does that now quite well
  • info: (new) Emit status for any state changes of a controller or actuator. So light on/off etc. All-Link groups would emit one change log for each endpoint in the All-Link group
  • debug: Enough content that we can debug someone else's installation remotely if they have problems and enable debug level.

What do you think about my proposed changes to info?

@teharris1
Copy link
Collaborator

teharris1 commented Mar 6, 2021 via email

@mstovenour
Copy link
Contributor Author

OK. while learning the code I'll add in the info level logs and submit a PR just for the logging enhancements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants