Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature #68: Only build bytecode files if option flag is used #244

Closed
wants to merge 2 commits into from

Conversation

brutus
Copy link

@brutus brutus commented May 7, 2015

See: #68. Since I generally like clean / less noisy project directories I think it's okay to default to not writing bytecode files (*.pyc) unless the option flag is set. Invoke tends to be pretty fast anyway and the possible speedup trough the bytecode files might be neglect able.

Not sure about tie ins to the configuration system

brutus added 2 commits May 5, 2015 12:58
Unless the `write-pyc` flag is given, no pyc files are generated. This
is archieved bey setting `sys.dont_write_bytecode = True`.
@bitprophet bitprophet added this to the 0.11 milestone May 11, 2015
@bitprophet
Copy link
Member

Thanks, added to milestone.

Re: configuration, I don't see any spots where we currently honor config files for CLI-oriented flags - most things impact run() (e.g. --echo) and thus aren't even inspected until the CLI module is done doing things.

We should probably honor this type of option (e.g. root, no-dedupe, collection, debug, etc - in addition to this new one) but I don't think it's a blocker here.

@bitprophet
Copy link
Member

Welp I let this sit so long it got obviated by updates to cli.py (now program.py). Manually porting this code & adding extra tests too n such. Will credit in changelog!

@bitprophet bitprophet closed this Jan 13, 2016
bitprophet added a commit that referenced this pull request Jan 13, 2016
Went a more direct route than #244 since it was more test-friendly.
Turned out to be less code too, not like it matters here...
bitprophet added a commit that referenced this pull request Jan 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants