Catch FileNotFoundError in config.py - issue #384

[indera]

[maintainer edit - this is re #384. github please parse subjects for references sometime ugggh]

[codecov-io]

Codecov Report

Merging #385 into master will decrease coverage by 0.59%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master     #385     +/-   ##
=========================================
- Coverage    93.5%   92.91%   -0.6%     
=========================================
  Files          21       20      -1     
  Lines        2141     1793    -348     
  Branches      377      307     -70     
=========================================
- Hits         2002     1666    -336     
+ Misses        100       93      -7     
+ Partials       39       34      -5

Impacted Files	Coverage Δ
invoke/config.py	90.58% <100%> (-4.11%)	⬇️
invoke/exceptions.py	68.85% <0%> (-19.39%)	⬇️
invoke/parser/argument.py	91.42% <0%> (-1.6%)	⬇️
invoke/runners.py	89.93% <0%> (-1.59%)	⬇️
invoke/platform.py	66.1% <0%> (-1.12%)	⬇️
invoke/util.py	87.27% <0%> (-1.07%)	⬇️
invoke/__init__.py	100% <0%> (ø)	⬆️
invoke/watchers.py
invoke/program.py	98.66% <0%> (+0.82%)	⬆️
... and 7 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24570f8...27ecc01. Read the comment docs.

[PatrickMassot]

It's very nice to fix #384 but why did you drop python 2.6 in the same PR??

Have you seen #364?

[bitprophet]

Thanks for this (& raising the issue itself in #384 - sadly I don't have the time nor expertise to have full international support in my initial code :D). Some feedback:

• As @PatrickMassot notes we still support 2.6 pending Consider dropping/deprecating Python 2.6 support #364, so please make sure the PR works there :)
• What's .ropeproject? I generally prefer people use their own gitignores and not the project's gitignore, for anything the project itself doesn't require for development. So dropping that part of the patch would be appreciated too.
• I'm slightly torn on the actual, core fix: obviously introspecting the error message for English is non-ideal, but I worry expanding the scope to simply "any OSError or IOError" could hide other subtypes of such errors.
  • Part of me wonders if it's worth testing specifically for FileNotFound on Python 3; but the syntactical overhead of doing that probably isn't worth it (until/when we drop Python 2).
  • Overall, though, the chance of some error at this point that is meaningfully different from "file not found" feels low, and users in those situations who see behavior they're not expecting, will hopefully enable logging. So yea. I'll probably merge this :)

[indera]

@bitprophet .ropeproject/ folder is generated by a vim python plugin I am using: https://github.com/klen/python-mode

[indera]

Fails on windows but other than that looks good to me