Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Available Potential implemented #152

Merged
merged 18 commits into from
Feb 22, 2019
Merged

Available Potential implemented #152

merged 18 commits into from
Feb 22, 2019

Conversation

jan-janssen
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Feb 20, 2019

Pull Request Test Coverage Report for Build 1087

  • 56 of 100 (56.0%) changed or added relevant lines in 7 files are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.1%) to 66.611%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pyiron/lammps/base.py 2 3 66.67%
pyiron/lammps/potential.py 5 11 45.45%
pyiron/vasp/potential.py 28 44 63.64%
pyiron/vasp/base.py 15 36 41.67%
Files with Coverage Reduction New Missed Lines %
pyiron/atomistics/master/murnaghan.py 2 50.63%
pyiron/vasp/interactive.py 5 35.9%
Totals Coverage Status
Change from base Build 1072: 0.1%
Covered Lines: 11260
Relevant Lines: 16904

💛 - Coveralls

Copy link
Member

@sudarsan-surendralal sudarsan-surendralal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use selected_atoms=None instead. And set it to [] only if None

@jan-janssen jan-janssen merged commit 825778b into master Feb 22, 2019
@jan-janssen jan-janssen deleted the available_potential branch February 26, 2019 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants