Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calc_md with pressure 0 corrected #656

Merged
merged 2 commits into from May 8, 2020
Merged

calc_md with pressure 0 corrected #656

merged 2 commits into from May 8, 2020

Conversation

samwaseda
Copy link
Member

Pointed out here

@samwaseda samwaseda requested a review from jan-janssen May 8, 2020 18:52
@jan-janssen jan-janssen added the bug Category: Something does not work label May 8, 2020
@samwaseda
Copy link
Member Author

Don't merge it yet I'm completing the unit tests

@jan-janssen
Copy link
Member

======================================================================
4024ERROR: test_dump_parser_water (lammps.test_base.TestLammps)
4025----------------------------------------------------------------------
4026Traceback (most recent call last):
4027  File "/home/travis/build/pyiron/pyiron/tests/lammps/test_base.py", line 286, in test_dump_parser_water
4028    pressure=0,
4029  File "/home/travis/build/pyiron/pyiron/pyiron/lammps/interactive.py", line 291, in calc_md
4030    delta_press=delta_press,
4031  File "/home/travis/build/pyiron/pyiron/pyiron/lammps/base.py", line 662, in calc_md
4032    rotation_matrix=self._prism.R
4033  File "/home/travis/build/pyiron/pyiron/pyiron/lammps/control.py", line 504, in calc_md
4034    pressure = self.pressure_to_lammps(pressure, rotation_matrix)
4035  File "/home/travis/build/pyiron/pyiron/pyiron/lammps/control.py", line 233, in pressure_to_lammps
4036    raise ValueError("Cells which are not orthorhombic or rectangular are incompatible with Lammps "
4037ValueError: Cells which are not orthorhombic or rectangular are incompatible with Lammps constant pressure calculations unless the entire pressure tensor is defined.The reason is that Lammps demands such cells be represented with an upper-triangular unit cell, thus a rotation between Lammps and pyiron coordinateframes is required; it is not possible to rotate the pressure tensor if any of its components is None.
4038
4039----------------------------------------------------------------------

Copy link
Member

@jan-janssen jan-janssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and solves my issue

@samwaseda samwaseda merged commit ce53a6d into master May 8, 2020
@samwaseda samwaseda deleted the calc_md branch May 8, 2020 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Category: Something does not work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants