Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Make Atoms() faster via caches" #305

Closed
wants to merge 1 commit into from
Closed

Revert "Make Atoms() faster via caches" #305

wants to merge 1 commit into from

Conversation

niklassiemer
Copy link
Member

Reverts #224: Fix Windows tests

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1084907745

  • 10 of 11 (90.91%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 68.068%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pyiron_atomistics/atomistics/structure/atoms.py 2 3 66.67%
Files with Coverage Reduction New Missed Lines %
pyiron_atomistics/atomistics/structure/periodic_table.py 1 82.84%
Totals Coverage Status
Change from base Build 1083664345: -0.01%
Covered Lines: 10910
Relevant Lines: 16028
💛 - Coveralls

@niklassiemer
Copy link
Member Author

Did not help.

@pyiron pyiron locked and limited conversation to collaborators Jul 31, 2021
@pyiron pyiron unlocked this conversation Jul 31, 2021
@niklassiemer niklassiemer marked this pull request as draft July 31, 2021 17:47
@samwaseda samwaseda deleted the revert-224-get_structure branch September 28, 2022 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@niklassiemer @coveralls