Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to removal of load_object #386

Merged
merged 1 commit into from
Oct 8, 2021
Merged

Adapt to removal of load_object #386

merged 1 commit into from
Oct 8, 2021

Conversation

pmrv
Copy link
Contributor

@pmrv pmrv commented Oct 7, 2021

Depends on this.

@pmrv pmrv added the enhancement New feature or request label Oct 7, 2021
@niklassiemer
Copy link
Member

This should be independent, shouldn't it? It is more like the other way round. If we remove this in base this method will break. However, the to_object functionality should already be fine?

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1316479245

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 69.751%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pyiron_atomistics/table/funct.py 0 1 0.0%
Totals Coverage Status
Change from base Build 1307989135: 0.0%
Covered Lines: 11414
Relevant Lines: 16364

💛 - Coveralls

@pmrv
Copy link
Contributor Author

pmrv commented Oct 7, 2021

This should be independent, shouldn't it? It is more like the other way round. If we remove this in base this method will break. However, the to_object functionality should already be fine?

Fair, this is actually applicable already.

@pmrv pmrv marked this pull request as ready for review October 7, 2021 14:59
@pmrv pmrv merged commit 372bd7e into master Oct 8, 2021
@delete-merged-branch delete-merged-branch bot deleted the load_objectg branch October 8, 2021 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants